OneSizeFitsQuorum commented on code in PR #13809:
URL: https://github.com/apache/iotdb/pull/13809#discussion_r1804717218
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/region/RegionCache.java:
##########
@@ -65,7 +65,7 @@ public synchronized void cacheHeartbeatSample(
return;
}
RegionStatus lastStatus = ((RegionHeartbeatSample)
getLastSample()).getStatus();
- if (lastStatus.equals(RegionStatus.Adding) ||
lastStatus.equals(RegionStatus.Removing)) {
Review Comment:
same as above. This change may occur some bugs
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/node/DataNodeHeartbeatCache.java:
##########
@@ -38,10 +38,6 @@ public DataNodeHeartbeatCache(int dataNodeId) {
@Override
public synchronized void updateCurrentStatistics() {
- // The Removing status can not be updated
Review Comment:
Why remove this line?Then the remove status maybe updated by Running or
Readonly or Unknown?
##########
integration-test/src/test/java/org/apache/iotdb/confignode/it/removedatanode/IoTDBRemoveDataNodeITFramework.java:
##########
@@ -88,7 +89,8 @@ public void successTest(
final int configNodeNum,
final int dataNodeNum,
final int removeDataNodeNum,
- final int dataRegionPerDataNode)
+ final int dataRegionPerDataNode,
+ final boolean needRestartRemoveDataNode)
Review Comment:
rejoinRemovedDataNode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
