JackieTien97 commented on code in PR #13878:
URL: https://github.com/apache/iotdb/pull/13878#discussion_r1836085683
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/extractor/dataregion/realtime/listener/PipeInsertionDataNodeListener.java:
##########
@@ -168,6 +169,12 @@ public DeletionResource listenToDeleteData(final String
regionId, final DeleteDa
return deletionResource;
}
+ public DeletionResource listenToDeleteData(
+ final String regionId, final RelationalDeleteDataNode node) {
+ // TODO: implement
+ return null;
Review Comment:
throw Exception may be better? @Caideyipi @SteveYurongSu can plan when to
support this.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/node/WALNode.java:
##########
@@ -170,6 +171,16 @@ public WALFlushListener log(long memTableId,
DeleteDataNode deleteDataNode) {
return log(walEntry);
}
+ @Override
+ public WALFlushListener log(long memTableId, RelationalDeleteDataNode
deleteDataNode) {
+ logger.debug(
Review Comment:
add if debug enabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
