HxpSerein commented on code in PR #14051:
URL: https://github.com/apache/iotdb/pull/14051#discussion_r1836692522
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RemoveDataNodeHandler.java:
##########
@@ -130,23 +130,40 @@ public void changeDataNodeStatus(
for (Map.Entry<Integer, TSStatus> entry :
changeDataNodeStatusContext.getResponseMap().entrySet()) {
- long currentTime = System.nanoTime();
-
int dataNodeId = entry.getKey();
NodeStatus nodeStatus = nodeStatusMap.get(dataNodeId);
RegionStatus regionStatus = RegionStatus.valueOf(nodeStatus.getStatus());
+
+ if (!isSucceed(entry.getValue())) {
+ LOGGER.error(
+ "{}, Failed to change DataNode status, dataNodeId={},
nodeStatus={}",
+ REMOVE_DATANODE_PROCESS,
+ dataNodeId,
+ nodeStatus);
+ continue;
+ }
+
// Force updating NodeStatus
+ long currentTime = System.nanoTime();
Review Comment:
`updateCurrentStatistics` will choose the latest sample, so I print the time
here to compare with the sample in the updateCurrentStatistics to check if it
is because of the race of normal hearbeat from DataNode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
