jt2594838 commented on code in PR #13878:
URL: https://github.com/apache/iotdb/pull/13878#discussion_r1839940330
##########
iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/tablemodel/CompactionWithAllNullRowsTest.java:
##########
@@ -263,9 +263,9 @@ public void testCompactionWithAllDeletion() throws
IOException, IllegalPathExcep
writer.endFile();
}
resource1
- .getModFile()
- .write(new Deletion(new MeasurementPath(deviceID, ""), Long.MAX_VALUE,
Long.MAX_VALUE));
Review Comment:
Done
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/recover/CompactionRecoverTask.java:
##########
@@ -274,28 +274,31 @@ private boolean checkIsTargetFilesComplete(
private boolean deleteFile(TsFileIdentifier tsFileIdentifier) {
boolean success = true;
// delete tsfile
- File file = tsFileIdentifier.getFileFromDataDirs();
- if (!checkAndDeleteFile(file)) {
+ File tsFile = tsFileIdentifier.getFileFromDataDirs();
+ if (!checkAndDeleteFile(tsFile)) {
success = false;
}
// delete resource file
- file = getFileFromDataDirs(tsFileIdentifier.getFilePath() +
TsFileResource.RESOURCE_SUFFIX);
- if (!checkAndDeleteFile(file)) {
+ File resourceFile =
+ getFileFromDataDirs(tsFileIdentifier.getFilePath() +
TsFileResource.RESOURCE_SUFFIX);
+ if (!checkAndDeleteFile(resourceFile)) {
success = false;
}
Review Comment:
Done
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/log/TsFileIdentifier.java:
##########
@@ -194,8 +195,9 @@ public File getFileFromDataDirsIfAnyAdjuvantFileExists() {
File file = FSFactoryProducer.getFSFactory().getFile(dataDir,
partialFileString);
if (file.exists()
|| new File(file.getAbsolutePath() +
TsFileResource.RESOURCE_SUFFIX).exists()
- || new File(file.getAbsolutePath() +
ModificationFile.FILE_SUFFIX).exists()
- || new File(file.getAbsolutePath() +
ModificationFile.COMPACTION_FILE_SUFFIX).exists()) {
+ || ModificationFileV1.getNormalMods(file).exists()
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
