jt2594838 commented on code in PR #13878:
URL: https://github.com/apache/iotdb/pull/13878#discussion_r1844922641
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/snapshot/SnapshotTaker.java:
##########
@@ -206,10 +206,10 @@ private boolean createSnapshot(List<TsFileResource>
resources, String snapshotId
createHardLink(
new File(snapshotTsFile.getAbsolutePath() +
TsFileResource.RESOURCE_SUFFIX),
new File(tsFile.getAbsolutePath() +
TsFileResource.RESOURCE_SUFFIX));
- if (resource.getModFile().exists()) {
+ if (resource.exclusiveModFileExists()) {
Review Comment:
Done
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/TsFileResource.java:
##########
@@ -109,8 +125,19 @@ public class TsFileResource implements PersistentResource {
/** time index */
private ITimeIndex timeIndex;
+ private Future<ModificationFile> exclusiveModFileFuture;
+ // this future suggest when the async recovery ends
+ private CompletableFuture<String> sharedModFilePathFuture;
+
+ private ModFileManagement modFileManagement;
+
@SuppressWarnings("squid:S3077")
- private volatile ModificationFile modFile;
+ private volatile ModificationFile exclusiveModFile;
+
+ private volatile ModificationFile sharedModFile;
+ private long shardModFileOffset;
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
