jt2594838 commented on code in PR #14146: URL: https://github.com/apache/iotdb/pull/14146#discussion_r1849450940
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java: ########## Review Comment: I am quite concerned about the readability of the code. The length of the array and its content are unclear when someone reads top-level methods like `insertTablet`. To figure it out, the reader must dig down via the call chain to `updateTsFileProcessorMetric`. I think sufficient comments or an abstraction with an inner class is needed to avoid such confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
