OneSizeFitsQuorum commented on PR #14115: URL: https://github.com/apache/iotdb/pull/14115#issuecomment-2490887422
| hi , why do no need node lock? if have some addnodeprocedure perform now, our remove other node, whether is effect? Hi, chao, this is because we have do check before executing RemoveDataNode Procedure(you could see the code in https://github.com/apache/iotdb/blob/master/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java#L619-L725). Currently, only one removeDataNode task is allowed globally, so there is no need for additional concurrency control during procedure execution, otherwise it may cause some mutual blocking with pipe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
