Cpaulyz commented on code in PR #14135:
URL: https://github.com/apache/iotdb/pull/14135#discussion_r1857929119
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/function/DropFunctionPlan.java:
##########
@@ -31,29 +32,37 @@
public class DropFunctionPlan extends ConfigPhysicalPlan {
+ private Model model;
private String functionName;
public DropFunctionPlan() {
super(ConfigPhysicalPlanType.DropFunction);
}
- public DropFunctionPlan(String functionName) {
+ public DropFunctionPlan(Model model, String functionName) {
super(ConfigPhysicalPlanType.DropFunction);
+ this.model = model;
this.functionName = functionName;
}
+ public Model getModel() {
+ return model;
+ }
+
public String getFunctionName() {
return functionName;
}
@Override
protected void serializeImpl(DataOutputStream stream) throws IOException {
stream.writeShort(getType().getPlanType());
+ ReadWriteIOUtils.write(model.getValue(), stream);
ReadWriteIOUtils.write(functionName, stream);
}
@Override
protected void deserializeImpl(ByteBuffer buffer) throws IOException {
+ model = Model.findByValue(ReadWriteIOUtils.readInt(buffer));
Review Comment:
Fixed. Split it into DropTableModelFunctionPlan and DropTreeModelFunctionPlan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
