JackieTien97 commented on code in PR #14205:
URL: https://github.com/apache/iotdb/pull/14205#discussion_r1858172565
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/ExplainAnalyzeNode.java:
##########
@@ -74,6 +68,8 @@ public PlanNode replaceChildren(List<PlanNode> newChildren) {
protected void serializeAttributes(ByteBuffer byteBuffer) {
PlanNodeType.EXPLAIN_ANALYZE.serialize(byteBuffer);
ReadWriteIOUtils.write(verbose, byteBuffer);
+ ReadWriteIOUtils.write(queryId, byteBuffer);
+ ReadWriteIOUtils.write(timeout, byteBuffer);
Review Comment:
throw exception for these serde methods and add comments for that.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java:
##########
@@ -142,6 +140,11 @@ public List<PlanNode> visitPlan(
return Collections.singletonList(newNode);
}
+ @Override
+ public List<PlanNode> visitExplainAnalyze(ExplainAnalyzeNode node,
PlanContext context) {
+ return genResult(node, context);
Review Comment:
call genResult for child
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
