OneSizeFitsQuorum commented on code in PR #14196:
URL: https://github.com/apache/iotdb/pull/14196#discussion_r1859893604
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/pipe/PipeConsensusServerImpl.java:
##########
@@ -510,6 +510,24 @@ public synchronized void
dropConsensusPipeToTargetPeer(Peer targetPeer)
}
}
+ public void startOtherConsensusPipesToTargetPeer(Peer targetPeer)
+ throws ConsensusGroupModifyPeerException {
+ final List<Peer> otherPeers = peerManager.getOtherPeers(thisNode);
+ for (Peer peer : otherPeers) {
+ if (peer.equals(targetPeer)) {
+ continue;
+ }
+ try {
+ consensusPipeManager.updateConsensusPipe(
Review Comment:
If a switchover leader is generated during the addpeer phase, the pipe state
of the new leader has not been started at this time, is there some corner case
that needs to be considered？
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/pipe/task/CreatePipeProcedureV2.java:
##########
@@ -203,7 +203,9 @@ public void
executeFromCalculateInfoForTask(ConfigNodeProcedureEnv env) {
}
pipeRuntimeMeta = new PipeRuntimeMeta(consensusGroupIdToTaskMetaMap);
- pipeRuntimeMeta.getStatus().set(PipeStatus.RUNNING);
+ if (!createPipeRequest.needManuallyStart) {
Review Comment:
should check issetxxx? or you should relay on the default value for boolean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
