Beyyes commented on code in PR #14148:
URL: https://github.com/apache/iotdb/pull/14148#discussion_r1861718144
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/source/relational/TableInnerJoinOperator.java:
##########
@@ -248,62 +228,140 @@ private void tryCachedNextRightTsBlock() throws
Exception {
}
}
- private long getCurrentLeftTime() {
- return leftBlock.getColumn(leftTimeColumnPosition).getLong(leftIndex);
- }
-
- private long getLeftEndTime() {
- return
leftBlock.getColumn(leftTimeColumnPosition).getLong(leftBlock.getPositionCount()
- 1);
+ private void mainJoinLoop() {
+ switch (joinKeyType.getTypeEnum()) {
+ case INT32:
+ case DATE:
+ intJoinLoop();
+ break;
+ case INT64:
+ case TIMESTAMP:
+ longJoinLoop();
+ break;
+ case FLOAT:
+ floatJoinLoop();
+ break;
+ case DOUBLE:
+ doubleJoinLoop();
+ break;
+ case STRING:
+ binaryJoinLoop();
+ break;
+ case BLOB:
+ case TEXT:
+ case BOOLEAN:
+ default:
Review Comment:
BLOB,TEXT,BOOLEAN types are also needed to be support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
