Pengzna commented on code in PR #14250:
URL: https://github.com/apache/iotdb/pull/14250#discussion_r1867199812
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java:
##########
@@ -329,68 +331,79 @@ private void executeProcedure(Procedure<Env> proc) {
LOG.warn("Rollback stack is null for {}", proc.getProcId());
return;
}
- do {
- if (!rootProcStack.acquire()) {
- if (rootProcStack.setRollback()) {
- switch (executeRootStackRollback(rootProcId, rootProcStack)) {
- case LOCK_ACQUIRED:
- break;
- case LOCK_EVENT_WAIT:
- LOG.info("LOCK_EVENT_WAIT rollback " + proc);
- rootProcStack.unsetRollback();
- break;
- case LOCK_YIELD_WAIT:
- rootProcStack.unsetRollback();
- scheduler.yield(proc);
- break;
- default:
- throw new UnsupportedOperationException();
- }
- } else {
- if (!proc.wasExecuted()) {
- switch (executeRollback(proc)) {
+ ProcedureLockState lockState = null;
+ try {
+ do {
+ if (!rootProcStack.acquire()) {
+ if (rootProcStack.setRollback()) {
+ lockState = executeRootStackRollback(rootProcId, rootProcStack);
+ switch (lockState) {
case LOCK_ACQUIRED:
break;
case LOCK_EVENT_WAIT:
- LOG.info("LOCK_EVENT_WAIT can't rollback child running for
{}", proc);
+ LOG.info("LOCK_EVENT_WAIT rollback " + proc);
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
