OneSizeFitsQuorum commented on code in PR #14433:
URL: https://github.com/apache/iotdb/pull/14433#discussion_r1886108763
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/pipe/PipeConsensusServerImpl.java:
##########
@@ -553,11 +553,20 @@ public void
waitPeersToTargetPeerTransmissionCompleted(Peer targetPeer)
isTransmissionCompleted = true;
for (Peer peer : otherPeers) {
if (!peer.equals(targetPeer)) {
- isTransmissionCompleted &=
- isRemotePeerConsensusPipesTransmissionCompleted(
- peer,
- Collections.singletonList(new ConsensusPipeName(peer,
targetPeer).toString()),
- isFirstCheckForOtherPeers);
+ try {
+ isTransmissionCompleted &=
+ isRemotePeerConsensusPipesTransmissionCompleted(
Review Comment:
do we need to add this for `waitTargetPeerToPeersTransmissionCompleted`?
##########
iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/pipe/PipeConsensus.java:
##########
@@ -407,6 +407,8 @@ public void removeRemotePeer(ConsensusGroupId groupId, Peer
peer) throws Consens
LOGGER.info("[{}] wait {} to release all resource...", CLASS_NAME, peer);
impl.waitReleaseAllRegionRelatedResource(peer);
} catch (ConsensusGroupModifyPeerException e) {
+ LOGGER.error(
Review Comment:
use warn log is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
