JackieTien97 commented on code in PR #14540:
URL: https://github.com/apache/iotdb/pull/14540#discussion_r1897608850
##########
integration-test/src/test/java/org/apache/iotdb/relational/it/query/recent/IoTDBTableAggregationIT.java:
##########
@@ -33,7 +33,7 @@
import static org.apache.iotdb.db.it.utils.TestUtils.prepareTableData;
import static org.apache.iotdb.db.it.utils.TestUtils.tableAssertTestFail;
import static org.apache.iotdb.db.it.utils.TestUtils.tableResultSetEqualTest;
-import static
org.apache.iotdb.relational.it.db.it.IoTDBMultiIDsWithAttributesTableIT.buildHeaders;
+import static
org.apache.iotdb.relational.it.db.it.IoTDBMultiTAGsWithAttributesTableIT.buildHeaders;
Review Comment:
change back
##########
iotdb-core/relational-grammar/src/main/antlr4/org/apache/iotdb/db/relational/grammar/sql/RelationalSql.g4:
##########
@@ -1088,7 +1089,6 @@ GROUPING: 'GROUPING';
GROUPS: 'GROUPS';
HAVING: 'HAVING';
HOUR: 'HOUR' | 'H';
-ID: 'ID';
Review Comment:
also remove MEASUREMENT
##########
integration-test/src/test/java/org/apache/iotdb/relational/it/db/it/IoTDBMultiDeviceTableIT.java:
##########
@@ -257,7 +257,7 @@ private static void insertData() {
}
@Test
- public void testMultiDeviceQueryAndDelete() {
+ public void testMulttageviceQueryAndDelete() {
Review Comment:
change back
##########
iotdb-core/relational-grammar/src/main/antlr4/org/apache/iotdb/db/relational/grammar/sql/RelationalSql.g4:
##########
@@ -1267,6 +1267,7 @@ SYSTEM: 'SYSTEM';
TABLE: 'TABLE';
TABLES: 'TABLES';
TABLESAMPLE: 'TABLESAMPLE';
+TAG: 'TAG';
Review Comment:
add TAG and FIELD to nonReserved
##########
example/client-cpp-example/src/TableModelSessionExample.cpp:
##########
@@ -32,13 +32,13 @@ void insertRelationalTablet() {
make_pair("device_id", TSDataType::TEXT),
make_pair("model", TSDataType::TEXT),
make_pair("temperature", TSDataType::FLOAT),
- make_pair("humidity", TSDataType::DOUBLE)
+ make_pair("humtagity", TSDataType::DOUBLE)
Review Comment:
change it back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
