Beyyes commented on code in PR #14438:
URL: https://github.com/apache/iotdb/pull/14438#discussion_r1906329620
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/TableOperatorGenerator.java:
##########
@@ -1491,6 +1494,60 @@ private BiFunction<Column, Integer, Column>
buildUpdateLastRowFunction(Type join
}
}
+ @Override
+ public Operator visitSemiJoin(SemiJoinNode node, LocalExecutionPlanContext
context) {
+ List<TSDataType> dataTypes = getOutputColumnTypes(node,
context.getTypeProvider());
+
+ Operator leftChild = node.getLeftChild().accept(this, context);
+ Operator rightChild = node.getRightChild().accept(this, context);
+
+ ImmutableMap<Symbol, Integer> sourceColumnNamesMap =
+ makeLayoutFromOutputSymbols(node.getSource().getOutputSymbols());
+ List<Symbol> sourceOutputSymbols = node.getSource().getOutputSymbols();
+ int[] sourceOutputSymbolIdx = new
int[node.getSource().getOutputSymbols().size()];
+ for (int i = 0; i < sourceOutputSymbolIdx.length; i++) {
+ Integer index = sourceColumnNamesMap.get(sourceOutputSymbols.get(i));
+ checkNotNull(index, "Source of SemiJoinNode doesn't contain
sourceOutputSymbol.");
+ sourceOutputSymbolIdx[i] = index;
+ }
+
+ ImmutableMap<Symbol, Integer> filteringSourceColumnNamesMap =
+ makeLayoutFromOutputSymbols(node.getRightChild().getOutputSymbols());
+
+ Integer sourceJoinKeyPosition =
sourceColumnNamesMap.get(node.getSourceJoinSymbol());
+ checkNotNull(sourceJoinKeyPosition, "Source of SemiJoinNode doesn't
contain sourceJoinSymbol.");
+
+ Integer filteringSourceJoinKeyPosition =
+ filteringSourceColumnNamesMap.get(node.getFilteringSourceJoinSymbol());
+ checkNotNull(
+ filteringSourceJoinKeyPosition,
+ "FilteringSource of SemiJoinNode doesn't contain
filteringSourceJoinSymbol.");
+
+ Type sourceJoinKeyType =
+
context.getTypeProvider().getTableModelType(node.getSourceJoinSymbol());
+
+ checkArgument(
+ sourceJoinKeyType
+ ==
context.getTypeProvider().getTableModelType(node.getFilteringSourceJoinSymbol()),
+ "Join key type mismatch.");
Review Comment:
I think `701` error code is better. And print the sourceJoinKeyType and
filteringSourceJoinKeyType is friendly for user.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/optimizations/PushPredicateIntoTableScan.java:
##########
@@ -751,6 +756,205 @@ private void appendSortNodeForMergeSortJoin(JoinNode
joinNode) {
joinNode.setRightChild(rightSortNode);
}
+ @Override
+ public PlanNode visitSemiJoin(SemiJoinNode node, RewriteContext context) {
+ Expression inheritedPredicate =
+ context.inheritedPredicate != null ? context.inheritedPredicate :
TRUE_LITERAL;
+ if (!extractConjuncts(inheritedPredicate)
+ .contains(node.getSemiJoinOutput().toSymbolReference())) {
+ return visitNonFilteringSemiJoin(node, context);
Review Comment:
Is there always a FilterNode(`expr`) above SemiJoin? So which sql can
satisfy this branch?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/node/SemiJoinNode.java:
##########
@@ -0,0 +1,153 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.queryengine.plan.relational.planner.node;
+
+import org.apache.iotdb.db.queryengine.plan.planner.plan.node.PlanNode;
+import org.apache.iotdb.db.queryengine.plan.planner.plan.node.PlanNodeId;
+import org.apache.iotdb.db.queryengine.plan.planner.plan.node.PlanNodeType;
+import org.apache.iotdb.db.queryengine.plan.planner.plan.node.PlanVisitor;
+import
org.apache.iotdb.db.queryengine.plan.planner.plan.node.process.TwoChildProcessNode;
+import org.apache.iotdb.db.queryengine.plan.relational.planner.Symbol;
+
+import com.google.common.collect.ImmutableList;
+
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.List;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static java.util.Objects.requireNonNull;
+
+public class SemiJoinNode extends TwoChildProcessNode {
Review Comment:
override equals
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanVisitor.java:
##########
@@ -750,6 +751,10 @@ public R visitJoin(
return visitTwoChildProcess(node, context);
}
+ public R visitSemiJoin(SemiJoinNode node, C context) {
+ return visitPlan(node, context);
Review Comment:
visitTwoChild is better?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/iterative/rule/TransformFilteringSemiJoinToInnerJoin.java:
##########
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.db.queryengine.plan.relational.planner.iterative.rule;
+
+import org.apache.iotdb.db.queryengine.plan.planner.plan.node.PlanNode;
+import org.apache.iotdb.db.queryengine.plan.relational.planner.Assignments;
+import org.apache.iotdb.db.queryengine.plan.relational.planner.Symbol;
+import org.apache.iotdb.db.queryengine.plan.relational.planner.iterative.Rule;
+import org.apache.iotdb.db.queryengine.plan.relational.planner.node.FilterNode;
+import org.apache.iotdb.db.queryengine.plan.relational.planner.node.JoinNode;
+import
org.apache.iotdb.db.queryengine.plan.relational.planner.node.ProjectNode;
+import
org.apache.iotdb.db.queryengine.plan.relational.planner.node.SemiJoinNode;
+import org.apache.iotdb.db.queryengine.plan.relational.sql.ast.Expression;
+import org.apache.iotdb.db.queryengine.plan.relational.utils.matching.Capture;
+import org.apache.iotdb.db.queryengine.plan.relational.utils.matching.Captures;
+import org.apache.iotdb.db.queryengine.plan.relational.utils.matching.Pattern;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.ImmutableMap;
+
+import java.util.List;
+import java.util.Optional;
+import java.util.function.Predicate;
+
+import static com.google.common.collect.ImmutableList.toImmutableList;
+import static
org.apache.iotdb.db.queryengine.plan.relational.planner.ExpressionSymbolInliner.inlineSymbols;
+import static
org.apache.iotdb.db.queryengine.plan.relational.planner.ir.IrUtils.and;
+import static
org.apache.iotdb.db.queryengine.plan.relational.planner.ir.IrUtils.extractConjuncts;
+import static
org.apache.iotdb.db.queryengine.plan.relational.planner.node.AggregationNode.singleAggregation;
+import static
org.apache.iotdb.db.queryengine.plan.relational.planner.node.AggregationNode.singleGroupingSet;
+import static
org.apache.iotdb.db.queryengine.plan.relational.planner.node.JoinNode.JoinType.INNER;
+import static
org.apache.iotdb.db.queryengine.plan.relational.planner.node.Patterns.filter;
+import static
org.apache.iotdb.db.queryengine.plan.relational.planner.node.Patterns.semiJoin;
+import static
org.apache.iotdb.db.queryengine.plan.relational.planner.node.Patterns.source;
+import static
org.apache.iotdb.db.queryengine.plan.relational.sql.ast.BooleanLiteral.TRUE_LITERAL;
+import static
org.apache.iotdb.db.queryengine.plan.relational.utils.matching.Capture.newCapture;
+
+/**
+ * Rewrite filtering semi-join to inner join.
+ *
+ * <p>Transforms:
+ *
+ * <pre>
+ * - Filter (semiJoinSymbol AND predicate)
+ * - SemiJoin (semiJoinSymbol <- (a IN b))
+ * source: plan A producing symbol a
+ * filtering source: plan B producing symbol b
+ * </pre>
+ *
+ * <p>Into:
+ *
+ * <pre>
+ * - Project (semiJoinSymbol <- TRUE)
+ * - Join INNER on (a = b), joinFilter (predicate with semiJoinSymbol
replaced with TRUE)
+ * - source
+ * - Aggregation distinct(b)
+ * - filtering source
+ * </pre>
+ */
+public class TransformFilteringSemiJoinToInnerJoin implements Rule<FilterNode>
{
Review Comment:
This rule is not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
