shizy818 commented on code in PR #14616:
URL: https://github.com/apache/iotdb/pull/14616#discussion_r1909674749
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/TVList.java:
##########
@@ -281,14 +430,20 @@ protected void cloneAs(TVList cloneList) {
cloneList.timestamps.add(cloneTime(timestampArray));
}
cloneList.rowCount = rowCount;
+ cloneList.seqRowCount = seqRowCount;
cloneList.sorted = sorted;
cloneList.maxTime = maxTime;
+ cloneList.minTime = minTime;
Review Comment:
Same as TVList clear. The entry method is actually clone not cloneAs.
```
public FloatTVList clone() {
FloatTVList cloneList = FloatTVList.newList();
cloneAs(cloneList);
cloneSlicesAndBitMap(cloneList);
for (float[] valueArray : values) {
cloneList.values.add(cloneValue(valueArray));
}
return cloneList;
}
```
Maybe I should abstract indices clone and clear. However bitmap of
AlignedTVList and TVList are different and it needs to deal with seperately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
