Caideyipi commented on code in PR #13158:
URL: https://github.com/apache/iotdb/pull/13158#discussion_r1926342845
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/user/LocalFileUserAccessor.java:
##########
@@ -281,47 +130,92 @@ public void saveUser(User user) throws IOException {
}
/**
- * Delete a user's user file.
+ * Deserialize a user from its user file.
*
- * @param username The name of the user to be deleted.
- * @return True if the file is successfully deleted, false if the file does
not exists.
- * @throws IOException when the file cannot be deleted.
+ * @param entityName The name of the user to be deserialized.
+ * @return The user object or null if no such user.
*/
@Override
- public boolean deleteUser(String username) throws IOException {
- File userProfile =
- SystemFileFactory.INSTANCE.getFile(
- userDirPath + File.separator + username +
IoTDBConstant.PROFILE_SUFFIX);
- File backFile =
- SystemFileFactory.INSTANCE.getFile(
- userDirPath + File.separator + username +
IoTDBConstant.PROFILE_SUFFIX + TEMP_SUFFIX);
- // The user may be not flush. So if not find the file, just return true;
- if (!userProfile.exists() && !backFile.exists()) {
- return true;
+ public User loadEntity(String entityName) throws IOException {
+ File entryFile = checkFileAvailable(entityName, "");
Review Comment:
entityFile
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/auth/role/IEntityManager.java:
##########
@@ -0,0 +1,85 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iotdb.commons.auth.role;
+
+import org.apache.iotdb.commons.auth.AuthException;
+import org.apache.iotdb.commons.auth.entity.PrivilegeUnion;
+import org.apache.iotdb.commons.auth.entity.Role;
+import org.apache.iotdb.commons.snapshot.SnapshotProcessor;
+
+import java.util.List;
+
+/** We can call user or role as entity of access control, they all can obtain
privileges */
+public interface IEntityManager extends SnapshotProcessor {
+
+ /**
+ * Get an entity object.
+ *
+ * @param entityName The name of the role.
+ * @return A role object whose name is entityName or null if such role does
not exist.
+ * @throws AuthException if exception is raised while getting the role.
+ */
+ Role getEntity(String entityName) throws AuthException;
+
+ /**
+ * Create a role/user with given entityName. New roles/users will only be
granted no privileges.
+ *
+ * @param entityName is not null or empty
+ * @return True if the role is successfully created, false when the role
already exists.
+ */
+ boolean createRole(String entityName);
+
+ /**
+ * Delete an entity.
+ *
+ * @param entityName the name of the user/role.
+ * @return boolean, true means we have the role in entityManager.
+ */
+ boolean deleteEntity(String entityName);
+
+ /**
+ * Grant a privilege to an entity.
+ *
+ * @param entityName The name of the entity to which the privilege should be
added.
+ * @param privilegeUnion The privilege will be granted to entity.
+ * @throws AuthException If the role does not exist or the privilege or the
path is illegal.
+ */
+ void grantPrivilegeToEntity(String entityName, PrivilegeUnion privilegeUnion)
+ throws AuthException;
+
+ /**
+ * Revoke a privilege on path from an entity.
+ *
+ * @param entityName The name of the entity from which the privilege should
be removed.
+ * @param privilegeUnion The privilege will be granted to entity.
+ * @throws AuthException If the role does not exist or the privilege or the
path is illegal.
+ */
+ void revokePrivilegeFromEntity(String entityName, PrivilegeUnion
privilegeUnion)
+ throws AuthException;
+
+ /** Re-initialize this object. */
+ void reset() throws AuthException;
+
+ /**
+ * List all users/roles.
+ *
+ * @return A list that contains names of all roles.
+ */
+ List<String> listAllEntries();
Review Comment:
listAllEntities
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
