CritasWang commented on code in PR #14656:
URL: https://github.com/apache/iotdb/pull/14656#discussion_r1942408512
##########
iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/Constant.java:
##########
@@ -25,7 +25,7 @@ private Constant() {}
public static final String GLOBAL_DB_NAME = "IoTDB";
- static final String METHOD_NOT_SUPPORTED = "Method not supported";
Review Comment:
add `TABLE_DIALECT="table"`
add `TREE_DIALECT="tree"`
And use it in the corresponding place
##########
iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java:
##########
@@ -309,12 +313,22 @@ public int getNetworkTimeout() {
@Override
public String getSchema() throws SQLException {
- throw new SQLException("Does not support getSchema");
+ return getDatabase();
Review Comment:
only `getSqlDialect().equals("table")`?
##########
iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBAbstractDatabaseMetadata.java:
##########
@@ -836,7 +836,7 @@ public boolean storesMixedCaseQuotedIdentifiers() throws
SQLException {
@Override
public String getIdentifierQuoteString() throws SQLException {
- return "' or \"";
+ return "";
Review Comment:
```
tree model is "`"
table model is "\""
```
##########
iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBConnection.java:
##########
@@ -309,12 +313,22 @@ public int getNetworkTimeout() {
@Override
public String getSchema() throws SQLException {
- throw new SQLException("Does not support getSchema");
+ return getDatabase();
}
@Override
public void setSchema(String arg0) throws SQLException {
- throw new SQLException("Does not support setSchema");
+ // changeDefaultDatabase(arg0);
Review Comment:
only `getSqlDialect().equals("table")`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
