XNX02 commented on code in PR #14922:
URL: https://github.com/apache/iotdb/pull/14922#discussion_r1971978716
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/connector/protocol/IoTDBConfigRegionConnector.java:
##########
@@ -144,45 +146,48 @@ private void doTransferWrapper(
private void doTransfer(final PipeConfigRegionWritePlanEvent
pipeConfigRegionWritePlanEvent)
throws PipeException {
- final Pair<IoTDBSyncClient, Boolean> clientAndStatus =
clientManager.getClient();
+ final List<Pair<IoTDBSyncClient, Boolean>> clientsAndStatuses =
+ shouldSendToAllClients
+ ? clientManager.getAllClients()
+ : Collections.singletonList(clientManager.getClient());
+ for (final Pair<IoTDBSyncClient, Boolean> clientAndStatus :
clientsAndStatuses) {
+ final TPipeTransferResp resp;
+ try {
+ final TPipeTransferReq req =
+ compressIfNeeded(
+ PipeTransferConfigPlanReq.toTPipeTransferReq(
+ pipeConfigRegionWritePlanEvent.getConfigPhysicalPlan()));
Review Comment:
Could you clarify what you meant by 'internal ByteBuffer needs to copy the
internal array'? It sounds that simply place the req outside the loop is not
enough in this situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
