SzyWilliam commented on code in PR #14866:
URL: https://github.com/apache/iotdb/pull/14866#discussion_r1972706193
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/cache/AbstractLoadCache.java:
##########
@@ -33,16 +38,35 @@ public abstract class AbstractLoadCache {
// Max heartbeat cache samples store size
private static final int MAXIMUM_WINDOW_SIZE = 100;
// The Status will be set to Unknown when the response time of heartbeat is
more than 20s
- protected static final long HEARTBEAT_TIMEOUT_TIME_IN_NS = 20_000_000_000L;
+ protected final long heartbeatTimeoutNs;
// Caching the recent MAXIMUM_WINDOW_SIZE heartbeat sample
protected final List<AbstractHeartbeatSample> slidingWindow;
// The current statistics calculated by the latest heartbeat sample
protected final AtomicReference<AbstractStatistics> currentStatistics;
+ protected final IFailureDetector failureDetector;
+
+ private static final ConfigNodeConfig CONF =
ConfigNodeDescriptor.getInstance().getConf();
+
protected AbstractLoadCache() {
this.currentStatistics = new AtomicReference<>();
this.slidingWindow = Collections.synchronizedList(new LinkedList<>());
+ this.heartbeatTimeoutNs = CONF.getFailureDetectorFixedThresholdInMs() *
1000_000L;
+ switch (CONF.getFailureDetector()) {
+ case IFailureDetector.PHI_ACCRUAL_DETECTOR:
+ this.failureDetector =
+ new PhiAccrualDetector(
+ CONF.getFailureDetectorPhiThreshold(),
+ CONF.getFailureDetectorPhiAcceptablePauseInMs() * 1000_000L,
+ CONF.getHeartbeatIntervalInMs() * 1000_000L,
+ CONF.getFailureDetectorPhiAcceptablePauseInMs() * 1000_000L);
Review Comment:
Fixed
##########
iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/manager/load/cache/detector/DetectorTest.java:
##########
@@ -0,0 +1,157 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.confignode.manager.load.cache.detector;
+
+import org.apache.iotdb.commons.cluster.NodeStatus;
+import org.apache.iotdb.confignode.manager.load.cache.AbstractHeartbeatSample;
+import org.apache.iotdb.confignode.manager.load.cache.node.NodeHeartbeatSample;
+
+import org.junit.Assert;
+import org.junit.Test;
+
+import java.util.Collections;
+import java.util.LinkedList;
+import java.util.List;
+
+public class DetectorTest {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
