ycycse commented on code in PR #15036:
URL: https://github.com/apache/iotdb/pull/15036#discussion_r1984419638
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/FragmentInstanceDispatcherImpl.java:
##########
@@ -151,11 +153,13 @@ private Future<FragInstanceDispatchResult>
dispatchRead(List<FragmentInstance> i
instance.getFragment().clearTypeProvider();
}
- long dispatchReadTime = System.nanoTime() - startTime;
- QUERY_EXECUTION_METRIC_SET.recordExecutionCost(DISPATCH_READ,
dispatchReadTime);
- queryContext.recordDispatchCost(dispatchReadTime);
+ long fragInstanceDispatchReadTime = System.nanoTime() -
fragInstanceStartTime;
+ QUERY_EXECUTION_METRIC_SET.recordExecutionCost(DISPATCH_READ,
fragInstanceDispatchReadTime);
Review Comment:
Wasn't the original monitoring metrics also cumulative? Why not use the same
approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
