Pengzna commented on code in PR #15122:
URL: https://github.com/apache/iotdb/pull/15122#discussion_r2000570024
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/region/ReconstructRegionProcedure.java:
##########
@@ -125,38 +124,6 @@ protected void rollbackState(
ConfigNodeProcedureEnv configNodeProcedureEnv, ReconstructRegionState
reconstructRegionState)
throws IOException, InterruptedException, ProcedureException {}
- @Override
- protected ProcedureLockState acquireLock(ConfigNodeProcedureEnv
configNodeProcedureEnv) {
- configNodeProcedureEnv.getSchedulerLock().lock();
- try {
- if (configNodeProcedureEnv.getRegionMigrateLock().tryLock(this)) {
- LOGGER.info("procedureId {} acquire lock.", getProcId());
- return ProcedureLockState.LOCK_ACQUIRED;
- }
- configNodeProcedureEnv.getRegionMigrateLock().waitProcedure(this);
-
- LOGGER.info("procedureId {} wait for lock.", getProcId());
- return ProcedureLockState.LOCK_EVENT_WAIT;
- } finally {
- configNodeProcedureEnv.getSchedulerLock().unlock();
- }
- }
-
- @Override
- protected void releaseLock(ConfigNodeProcedureEnv configNodeProcedureEnv) {
Review Comment:
maybe still need to override this method? As we need to
wakeWaitingProcedures to let scheduler run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
