OneSizeFitsQuorum commented on code in PR #15171:
URL: https://github.com/apache/iotdb/pull/15171#discussion_r2010134380
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/service/TopologyService.java:
##########
@@ -243,8 +243,14 @@ private synchronized void topologyProbing() {
}
}
- private void logAsymmetricPartition(final Map<Integer, Set<Integer>>
partitioned) {
+ private void logAsymmetricPartition(
+ final Map<Integer, Set<Integer>> partitioned, final int totalNodes) {
for (final int fromId : partitioned.keySet()) {
+ final Set<Integer> unreachable = partitioned.get(fromId);
Review Comment:
If a new confignode comes online and a datanode goes down, heartbeats won't
have any samples for that node. This node will not be recorded in partitioned,
so it is not correct to print the asymmetric network partition part, and all
other nodes will print this node.
I feel that we should check whether there is a symmetric or asymmetric
network partition according to latestTopology, because there is a key
corresponding to each node whether it is online or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
