OneSizeFitsQuorum commented on code in PR #15181: URL: https://github.com/apache/iotdb/pull/15181#discussion_r2015609806
########## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template: ########## @@ -242,6 +242,27 @@ dn_data_dirs=data/datanode/data # Datatype: String dn_multi_dir_strategy=SequenceStrategy +# load_disk_select_strategy +# The strategy is used to choose a proper disk for loading tsfile. +# The info of the two strategies are as follows: +# 1. MIN_IO_FIRST: the system will try to choose the same disk as tsFileToLoad for loading. +# 2. DISK_STORAGE_BALANCE_FIRST: the system will make the disk choice that balance storage as much as possible. +# If this property is unset, system will use MIN_IO_FIRST as default strategy because storage-balance is ensured with higher priority. Review Comment: typo? default is DISK_STORAGE_BALANCE_FIRST? ########## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template: ########## @@ -242,6 +242,27 @@ dn_data_dirs=data/datanode/data # Datatype: String dn_multi_dir_strategy=SequenceStrategy +# load_disk_select_strategy +# The strategy is used to choose a proper disk for loading tsfile. +# The info of the two strategies are as follows: +# 1. MIN_IO_FIRST: the system will try to choose the same disk as tsFileToLoad for loading. +# 2. DISK_STORAGE_BALANCE_FIRST: the system will make the disk choice that balance storage as much as possible. Review Comment: In fact, for the DISK_STORAGE_BALANCE_FIRST policy, which applies the storage engine's default multi-disk policy, this is not necessarily the balancing policy, so it feels like we need to rename this and update the description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
