Copilot commented on code in PR #15003:
URL: https://github.com/apache/iotdb/pull/15003#discussion_r2018058122
##########
iotdb-client/cli/src/main/java/org/apache/iotdb/tool/tsfile/ImportTsFileLocally.java:
##########
@@ -49,6 +53,18 @@ public void loadTsFile() {
}
}
+ private String buildLoadSql(String filePath) {
+ List<String> parameters = new ArrayList<>();
+ if (!verify) {
+ parameters.add(String.format("\"%s\"=false", VERIFY_KEY));
+ }
+ if (databaseName != null) {
+ parameters.add(String.format("\"%s\"=\"%s\"", DATABASE_NAME_KEY,
databaseName));
+ }
+ String paramStr = String.join(",", parameters);
+ return String.format("load '%s' WITH (%s)", filePath, paramStr);
Review Comment:
If both verify is true and databaseName is null, 'paramStr' may be empty
resulting in an SQL statement with an empty WITH clause (i.e., WITH ()).
Consider conditionally appending the WITH clause only when parameters are
provided.
```suggestion
if (paramStr.isEmpty()) {
return String.format("load '%s'", filePath);
} else {
return String.format("load '%s' WITH (%s)", filePath, paramStr);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
