shuwenwei commented on code in PR #15290:
URL: https://github.com/apache/iotdb/pull/15290#discussion_r2038928077
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/modification/TreeDeletionEntry.java:
##########
@@ -133,16 +134,17 @@ public boolean affects(IDeviceID deviceID, long
startTime, long endTime) {
@Override
public boolean affects(IDeviceID deviceID) {
try {
+ PartialPath deviceIdPath =
+
DataNodeDevicePathCache.getInstance().getPartialPath(deviceID.toString());
Review Comment:
The key of this cache is string and there are a lot of uses to get the value
directly through string. Compared to constructing PartialPath directly, the
cost of toString may not be obvious
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]