FearfulTomcat27 opened a new pull request, #15323: URL: https://github.com/apache/iotdb/pull/15323
This pull request includes changes to the `IoTDBGreatestLeastTableIT` integration test and improvements to the `BooleanGreatestColumnTransformer` and `BooleanLeastColumnTransformer` classes. The most important changes are the addition of new test cases and improvements to the boolean transformation logic. Improvements to integration tests: * [`integration-test/src/test/java/org/apache/iotdb/relational/it/query/old/query/IoTDBGreatestLeastTableIT.java`](diffhunk://#diff-3ebb39862466df9835f4759c18ce131c3bf343a81bc3f07102b35dc25e7d1472R55-R56): Added new boolean values to the `boolean_table` and updated the expected results in the `testBooleanTypeGreatestFunction` and `testBooleanTypeLeastFunction` methods to reflect these changes. [[1]](diffhunk://#diff-3ebb39862466df9835f4759c18ce131c3bf343a81bc3f07102b35dc25e7d1472R55-R56) [[2]](diffhunk://#diff-3ebb39862466df9835f4759c18ce131c3bf343a81bc3f07102b35dc25e7d1472L173-R175) [[3]](diffhunk://#diff-3ebb39862466df9835f4759c18ce131c3bf343a81bc3f07102b35dc25e7d1472L182-R184) Codebase simplification: * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/multi/BooleanGreatestColumnTransformer.java`](diffhunk://#diff-a69fd35004e490dd715a8edbc2324720ab48e31e5c06f0763e0330f39bcf4c03L40-R40): Replaced `break` with `return` to improve the boolean transformation logic. * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/multi/BooleanLeastColumnTransformer.java`](diffhunk://#diff-cc0b0519ca19e7c38c1594a7edef2e3c07706bbb5ed975ab1a9550afec7acd67L39-R39): Replaced `break` with `return` to improve the boolean transformation logic.[Copilot is generating a summary...] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
