liyuheng55555 commented on code in PR #15282: URL: https://github.com/apache/iotdb/pull/15282#discussion_r2043842770
########## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/region/GreedyCopySetRegionGroupAllocator.java: ########## Review Comment: Does the execution of the `removeNodeReplicaSelect` function **not strongly coupled** with `GreedyCopySetRegionGroupAllocator`? From my observation, this coupling only exists in the three class members: `regionCounter`, `databaseRegionCounter`, and `combinationCounter`. In this case, perhaps placing `removeNodeReplicaSelect` in a new class would make things clearer, as the original class and algorithm are already complex enough. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
