Caideyipi commented on code in PR #15112:
URL: https://github.com/apache/iotdb/pull/15112#discussion_r2048070231
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/subtask/connector/PipeConnectorSubtaskManager.java:
##########
@@ -156,6 +160,17 @@ public synchronized String register(
final PipeConnectorSubtaskLifeCycle pipeConnectorSubtaskLifeCycle =
new PipeConnectorSubtaskLifeCycle(executor, pipeConnectorSubtask,
pendingQueue);
pipeConnectorSubtaskLifeCycleList.add(pipeConnectorSubtaskLifeCycle);
+
+ if (pipeConnector instanceof IoTDBDataNodeSyncConnector) {
+ attributeSortedStringToSinkClusterIdsMap.put(
+ attributeSortedString,
+ ((IoTDBDataNodeSyncConnector)
pipeConnector).getEndPointsClusterIds());
Review Comment:
Better put this in "IoTDBConnector"....
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/InsertBaseStatement.java:
##########
@@ -109,6 +109,8 @@ public abstract class InsertBaseStatement extends Statement
implements Accountab
protected long ramBytesUsed = Long.MIN_VALUE;
+ protected String originClusterId;
Review Comment:
Is it used?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/LoadTsFileStatement.java:
##########
@@ -62,6 +62,7 @@ public class LoadTsFileStatement extends Statement {
private long tabletConversionThresholdBytes = -1;
private boolean autoCreateDatabase = true;
private boolean isGeneratedByPipe = false;
+ private String originClusterId;
Review Comment:
Is it used?
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/extractor/IoTDBNonDataRegionExtractor.java:
##########
@@ -284,6 +291,14 @@ protected abstract Optional<PipeWritePlanEvent>
trimRealtimeEventByPipePattern(
protected abstract void confineHistoricalEventTransferTypes(final
PipeSnapshotEvent event);
+ public Set<String> getSinkClusterIds() {
Review Comment:
May be useless
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/LogicalPlanVisitor.java:
##########
@@ -491,6 +491,7 @@ public PlanNode visitInsertRow(InsertRowStatement
insertRowStatement, MPPQueryCo
insertRowStatement.getValues(),
insertRowStatement.isNeedInferType());
insertNode.setFailedMeasurementNumber(insertRowStatement.getFailedMeasurementNumber());
+ insertNode.setOriginClusterId(insertRowStatement.getOriginClusterId());
Review Comment:
Do we really need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
