OneSizeFitsQuorum commented on code in PR #15436:
URL: https://github.com/apache/iotdb/pull/15436#discussion_r2065744229
##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/ConfigNodeProcedureEnv.java:
##########
@@ -185,37 +185,37 @@ public boolean invalidateCache(final String
storageGroupName) throws IOException
}
}
- if (nodeStatus == NodeStatus.Running) {
- // Always invalidate PartitionCache first
- final TSStatus invalidatePartitionStatus =
- (TSStatus)
- SyncDataNodeClientPool.getInstance()
- .sendSyncRequestToDataNodeWithRetry(
-
dataNodeConfiguration.getLocation().getInternalEndPoint(),
- invalidateCacheReq,
- CnToDnSyncRequestType.INVALIDATE_PARTITION_CACHE);
-
- final TSStatus invalidateSchemaStatus =
- (TSStatus)
- SyncDataNodeClientPool.getInstance()
- .sendSyncRequestToDataNodeWithRetry(
-
dataNodeConfiguration.getLocation().getInternalEndPoint(),
- invalidateCacheReq,
- CnToDnSyncRequestType.INVALIDATE_SCHEMA_CACHE);
-
- if (!verifySucceed(invalidatePartitionStatus, invalidateSchemaStatus))
{
- LOG.error(
- "Invalidate cache failed, invalidate partition cache status is
{}, invalidate schemaengine cache status is {}",
- invalidatePartitionStatus,
- invalidateSchemaStatus);
- return false;
- }
- } else if (nodeStatus == NodeStatus.Unknown) {
+ if (nodeStatus == NodeStatus.Unknown) {
LOG.warn(
"Invalidate cache failed, because DataNode {} is Unknown",
dataNodeConfiguration.getLocation().getInternalEndPoint());
return false;
}
+
+ // Always invalidate PartitionCache first
+ final TSStatus invalidatePartitionStatus =
+ (TSStatus)
+ SyncDataNodeClientPool.getInstance()
+ .sendSyncRequestToDataNodeWithRetry(
+
dataNodeConfiguration.getLocation().getInternalEndPoint(),
+ invalidateCacheReq,
+ CnToDnSyncRequestType.INVALIDATE_PARTITION_CACHE);
+
+ final TSStatus invalidateSchemaStatus =
+ (TSStatus)
+ SyncDataNodeClientPool.getInstance()
+ .sendSyncRequestToDataNodeWithRetry(
+
dataNodeConfiguration.getLocation().getInternalEndPoint(),
+ invalidateCacheReq,
+ CnToDnSyncRequestType.INVALIDATE_SCHEMA_CACHE);
+
+ if (!verifySucceed(invalidatePartitionStatus, invalidateSchemaStatus)) {
+ LOG.error(
Review Comment:
may use warn log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
