Copilot commented on code in PR #15469:
URL: https://github.com/apache/iotdb/pull/15469#discussion_r2078817869
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/aggregate/operator/processor/StandardStatisticsOperatorProcessor.java:
##########
@@ -71,6 +77,8 @@ public Set<Supplier<IntermediateResultOperator>>
getIntermediateResultOperatorSu
() -> new IntegralPoweredSumOperator(1),
() -> new IntegralPoweredSumOperator(2),
() -> new IntegralPoweredSumOperator(3),
- () -> new IntegralPoweredSumOperator(4))));
+ () -> new IntegralPoweredSumOperator(4),
+ MaxOperator::new,
Review Comment:
[nitpick] Ensure that the ordering of supplier operator additions reflects
the intended operator evaluation sequence for clarity and maintainability.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/aggregate/operator/intermediateresult/sametype/numeric/MaxOperator.java:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package
org.apache.iotdb.db.pipe.processor.aggregate.operator.intermediateresult.sametype.numeric;
+
+public class MaxOperator extends AbstractSameTypeNumericOperator {
+ @Override
+ public String getName() {
+ return "max";
+ }
+
+ @Override
+ public boolean initAndGetIsSupport(int initialInput, long initialTimestamp) {
+ intValue = initialInput;
+ return super.initAndGetIsSupport(initialInput, initialTimestamp);
+ }
+
+ @Override
+ public boolean initAndGetIsSupport(long initialInput, long initialTimestamp)
{
Review Comment:
[nitpick] For consistency with other similar operator implementations,
consider declaring the method parameters as final.
```suggestion
public boolean initAndGetIsSupport(final int initialInput, final long
initialTimestamp) {
intValue = initialInput;
return super.initAndGetIsSupport(initialInput, initialTimestamp);
}
@Override
public boolean initAndGetIsSupport(final long initialInput, final long
initialTimestamp) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
