761417898 commented on code in PR #15439:
URL: https://github.com/apache/iotdb/pull/15439#discussion_r2081256146
##########
iotdb-client/client-cpp/src/main/Session.cpp:
##########
@@ -46,162 +47,73 @@ TSDataType::TSDataType getTSDataTypeFromString(const
string &str) {
return TSDataType::INVALID_DATATYPE;
}
-void RpcUtils::verifySuccess(const TSStatus &status) {
- if (status.code == TSStatusCode::MULTIPLE_ERROR) {
- verifySuccess(status.subStatus);
- return;
- }
- if (status.code != TSStatusCode::SUCCESS_STATUS
- && status.code != TSStatusCode::REDIRECTION_RECOMMEND) {
- throw ExecutionException(to_string(status.code) + ": " +
status.message, status);
- }
-}
-
-void RpcUtils::verifySuccessWithRedirection(const TSStatus &status) {
- verifySuccess(status);
- if (status.__isset.redirectNode) {
- throw RedirectException(to_string(status.code) + ": " +
status.message, status.redirectNode);
- }
- if (status.__isset.subStatus) {
- auto statusSubStatus = status.subStatus;
- vector<TEndPoint> endPointList(statusSubStatus.size());
- int count = 0;
- for (TSStatus subStatus : statusSubStatus) {
- if (subStatus.__isset.redirectNode) {
- endPointList[count++] = subStatus.redirectNode;
- } else {
- TEndPoint endPoint;
- endPointList[count++] = endPoint;
- }
- }
- if (!endPointList.empty()) {
- throw RedirectException(to_string(status.code) + ": " +
status.message, endPointList);
- }
- }
-}
-
-void RpcUtils::verifySuccess(const vector<TSStatus> &statuses) {
- for (const TSStatus &status: statuses) {
- if (status.code != TSStatusCode::SUCCESS_STATUS) {
- throw BatchExecutionException(status.message, statuses);
- }
- }
-}
-
-TSStatus RpcUtils::getStatus(TSStatusCode::TSStatusCode tsStatusCode) {
- TSStatus status;
- status.__set_code(tsStatusCode);
- return status;
-}
-
-TSStatus RpcUtils::getStatus(int code, const string &message) {
- TSStatus status;
- status.__set_code(code);
- status.__set_message(message);
- return status;
-}
-
-shared_ptr<TSExecuteStatementResp>
RpcUtils::getTSExecuteStatementResp(TSStatusCode::TSStatusCode tsStatusCode) {
- TSStatus status = getStatus(tsStatusCode);
- return getTSExecuteStatementResp(status);
-}
-
-shared_ptr<TSExecuteStatementResp>
-RpcUtils::getTSExecuteStatementResp(TSStatusCode::TSStatusCode tsStatusCode,
const string &message) {
- TSStatus status = getStatus(tsStatusCode, message);
- return getTSExecuteStatementResp(status);
-}
-
-shared_ptr<TSExecuteStatementResp> RpcUtils::getTSExecuteStatementResp(const
TSStatus &status) {
- shared_ptr<TSExecuteStatementResp> resp(new TSExecuteStatementResp());
- TSStatus tsStatus(status);
- resp->status = tsStatus;
- return resp;
-}
-
-shared_ptr<TSFetchResultsResp>
RpcUtils::getTSFetchResultsResp(TSStatusCode::TSStatusCode tsStatusCode) {
- TSStatus status = getStatus(tsStatusCode);
- return getTSFetchResultsResp(status);
-}
-
-shared_ptr<TSFetchResultsResp>
-RpcUtils::getTSFetchResultsResp(TSStatusCode::TSStatusCode tsStatusCode, const
string &appendMessage) {
- TSStatus status = getStatus(tsStatusCode, appendMessage);
- return getTSFetchResultsResp(status);
-}
-
-shared_ptr<TSFetchResultsResp> RpcUtils::getTSFetchResultsResp(const TSStatus
&status) {
- shared_ptr<TSFetchResultsResp> resp(new TSFetchResultsResp());
- TSStatus tsStatus(status);
- resp->__set_status(tsStatus);
- return resp;
-}
-
void Tablet::createColumns() {
for (size_t i = 0; i < schemas.size(); i++) {
TSDataType::TSDataType dataType = schemas[i].second;
switch (dataType) {
- case TSDataType::BOOLEAN:
- values[i] = new bool[maxRowNumber];
- break;
- case TSDataType::INT32:
- values[i] = new int[maxRowNumber];
- break;
- case TSDataType::INT64:
- values[i] = new int64_t[maxRowNumber];
- break;
- case TSDataType::FLOAT:
- values[i] = new float[maxRowNumber];
- break;
- case TSDataType::DOUBLE:
- values[i] = new double[maxRowNumber];
- break;
- case TSDataType::TEXT:
- values[i] = new string[maxRowNumber];
- break;
- default:
- throw UnSupportedDataTypeException(string("Data type ") +
to_string(dataType) + " is not supported.");
+ case TSDataType::BOOLEAN:
+ values[i] = new bool[maxRowNumber];
+ break;
+ case TSDataType::INT32:
+ values[i] = new int[maxRowNumber];
+ break;
+ case TSDataType::INT64:
+ values[i] = new int64_t[maxRowNumber];
+ break;
+ case TSDataType::FLOAT:
+ values[i] = new float[maxRowNumber];
+ break;
+ case TSDataType::DOUBLE:
+ values[i] = new double[maxRowNumber];
+ break;
+ case TSDataType::TEXT:
+ values[i] = new string[maxRowNumber];
+ break;
+ default:
+ throw UnSupportedDataTypeException(string("Data type ") +
to_string(dataType) + " is not supported.");
}
}
}
void Tablet::deleteColumns() {
for (size_t i = 0; i < schemas.size(); i++) {
+ if (values[i]) continue;
Review Comment:
Implement copy constructor/assignment
Add valgrind checks in unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
