Copilot commented on code in PR #15522:
URL: https://github.com/apache/iotdb/pull/15522#discussion_r2095372645
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/parser/AstBuilder.java:
##########
@@ -2386,8 +2385,8 @@ public Node
visitJoinRelation(RelationalSqlParser.JoinRelationContext ctx) {
joinType = Join.Type.INNER;
}
- if (criteria instanceof AsofJoinOn && joinType != Join.Type.INNER) {
- throw new SemanticException("ASOF JOIN is only support INNER type now");
+ if (criteria instanceof AsofJoinOn && joinType != Join.Type.INNER &&
timeDuration != null) {
+ throw new SemanticException("Tolerance in ASOF JOIN is only support
INNER type now");
Review Comment:
Grammar in this error message is awkward; consider revising to something
like: "Tolerance in ASOF JOIN is only supported for INNER join".
```suggestion
throw new SemanticException("Tolerance in ASOF JOIN is only supported
for INNER join");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
