JackieTien97 commented on code in PR #15628:
URL: https://github.com/apache/iotdb/pull/15628#discussion_r2127848572
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/builtin/relational/tvf/VariationTableFunction.java:
##########
@@ -147,13 +234,20 @@ public void finish(
outputWindow(properColumnBuilders, passThroughIndexBuilder);
}
- private void outputWindow(
+ protected void outputWindow(
List<ColumnBuilder> properColumnBuilders, ColumnBuilder
passThroughIndexBuilder) {
+ boolean increaseIndex = false;
for (long i = currentStartIndex; i < curIndex; i++) {
+ if (!skipIndex.isEmpty() && i == skipIndex.peek()) {
+ // skip the index if it is in the skip queue
+ skipIndex.poll();
+ continue;
+ }
Review Comment:
we should also output those null line., like 1, null, null, 1, null, 2,
null, 2, 3, null, 3, null,
if ignore_null => true:
first group contains 1, null, null, 1, null
secodn group contains 2, null, 2,
third group contains 3, null, 3, null
if ignore_null => false:
first group contains 1
second group contains null, null
third group contains 1
forth group contains null
fifth group contains 2
sixth group contains null
seventh group contains 2
eighth group contains 3
ninth group contains null
tenth group contains 3
eleventh group contains null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
