761417898 commented on code in PR #15680:
URL: https://github.com/apache/iotdb/pull/15680#discussion_r2137343284
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/security/encrypt/MessageDigestEncrypt.java:
##########
@@ -29,16 +29,15 @@
public class MessageDigestEncrypt implements AsymmetricEncrypt {
private static final Logger logger =
LoggerFactory.getLogger(MessageDigestEncrypt.class);
- private static final String ENCRYPT_ALGORITHM = "MD5";
private static final String STRING_ENCODING = "utf-8";
Review Comment:
You're right. In Java, both SHA - 256 and MD5 use the MessageDigest class,
and we just need to pass different algorithm names when calling
MessageDigest.getInstance(). Implementing another AsymmetricEncrypt like
SHA256MessageDigestEncrypt would be redundant as it's essentially the same
logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
