Copilot commented on code in PR #15779:
URL: https://github.com/apache/iotdb/pull/15779#discussion_r2154318502
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java:
##########
@@ -840,6 +840,25 @@ private boolean isSnapshotMode(final PipeParameters
parameters) {
return isSnapshotMode;
}
+ ///////////////////////// Shutdown Logic /////////////////////////
+
+ public void persistAllProgressIndexLocally() {
+ if (!tryReadLockWithTimeOut(10)) {
Review Comment:
[nitpick] Avoid using a magic number for the timeout; extract '10' into a
named constant or configuration parameter for clarity and flexibility.
```suggestion
if (!tryReadLockWithTimeOut(DEFAULT_READ_LOCK_TIMEOUT_SECONDS)) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
