ycycse commented on code in PR #15799:
URL: https://github.com/apache/iotdb/pull/15799#discussion_r2163578820


##########
iotdb-core/ainode/ainode/core/ingress/iotdb.py:
##########
@@ -84,9 +84,9 @@ def __init__(
             zone_id=time_zone,
         )
         self.session.open(False)
+        self.use_rate = use_rate
+        self.offset_rate = offset_rate

Review Comment:
   I think these two names are ambiguous. 
   * If we only define the training set by its size, how can we get the 
validation set, considering the DataLoader shuffles the indices randomly.
   * And why we need randow offset in one window, we already get the window 
randomly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to