Copilot commented on code in PR #15917:
URL: https://github.com/apache/iotdb/pull/15917#discussion_r2206491548
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/v2/handler/QueryDataSetHandler.java:
##########
@@ -258,6 +255,30 @@ private static Response fillQueryDataSetWithoutTimestamps(
return Response.ok().entity(targetDataSet).build();
}
+ private static void addTypedValueToTarget(
Review Comment:
[nitpick] The addTypedValueToTarget logic is duplicated across REST v1, v2,
and table handlers. Consider extracting it into a shared utility class to
reduce code duplication and simplify future updates.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/rest/table/v1/handler/QueryDataSetHandler.java:
##########
@@ -116,6 +115,30 @@ public static Response fillQueryDataSet(
return Response.ok().entity(targetDataSet).build();
}
+ private static void addTypedValueToTarget(
Review Comment:
[nitpick] This addTypedValueToTarget method repeats the same logic as in the
REST v2 handler. Extracting it into a common helper would improve
maintainability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
