CritasWang commented on code in PR #15961:
URL: https://github.com/apache/iotdb/pull/15961#discussion_r2212452383
##########
scripts/tools/ops/backup.sh:
##########
@@ -136,4 +138,4 @@ fi
IOTDB_CLI_CONF=${IOTDB_HOME}/conf
iotdb_cli_params="-Dlogback.configurationFile=${IOTDB_CLI_CONF}/logback-backup.xml"
-exec nohup "$JAVA" -DIOTDB_HOME=${IOTDB_HOME} $iotdb_cli_params -cp
"$CLASSPATH" "$MAIN_CLASS" "$@" >/dev/null 2>&1 <&- &
+exec nohup "$JAVA" $JAVA_OPTS -DIOTDB_HOME=${IOTDB_HOME} $iotdb_cli_params -cp
"$CLASSPATH" "$MAIN_CLASS" "$@" >/dev/null 2>&1 <&- &
Review Comment:
$JVM_OPTS
##########
scripts/conf/datanode-env.sh:
##########
@@ -203,6 +203,8 @@ if [ -z $JAVA ] ; then
exit 1;
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
Review Comment:
remove this, append to IOTDB_JVM_OPTS
##########
scripts/sbin/start-datanode.sh:
##########
@@ -130,7 +130,7 @@ if [ "x$SHOW_VERSION" != "x" ]; then
else
JAVA=java
fi
- exec "$JAVA" -cp "$CLASSPATH" $IOTDB_JVM_OPTS
"-Dlogback.configurationFile=${IOTDB_LOG_CONFIG}" "$classname"
+ exec "$JAVA" -cp "$CLASSPATH" $JVM_OPTS $IOTDB_JVM_OPTS
"-Dlogback.configurationFile=${IOTDB_LOG_CONFIG}" "$classname"
Review Comment:
keep old code
##########
scripts/tools/schema/print-schema-log.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.schema.MLogParser
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
```
"$JAVA" "$JVM_OPTS" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
```
##########
scripts/tools/tsfile/print-iotdb-data-dir.sh:
##########
@@ -41,12 +41,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.IoTDBDataDirViewer
-"$JAVA" -cp "$CLASSPATH"
"-Dlogback.configurationFile=${IOTDB_HOME}/conf/logback-tool.xml" "$MAIN_CLASS"
"$@"
+"$JAVA" -cp "$CLASSPATH"
"-Dlogback.configurationFile=${IOTDB_HOME}/conf/logback-tool.xml" "$JVM_OPTS"
"$MAIN_CLASS" "$@"
Review Comment:
$JVM-OPTS should follow closely behind "$JAVA"
##########
scripts/tools/tsfile/check-overlap-sequence-files-and-repair.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.validate.TsFileOverlapValidationAndRepairTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
"$JAVA" "$JVM_OPTS" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
##########
scripts/tools/ops/collect-info.sh:
##########
@@ -217,6 +217,7 @@ mkdir -p $IOTDB_HOME/$COLLECTION_DIR/logs
echo Unable to find java executable. Check JAVA_HOME and PATH
environment variables. > /dev/stderr
exit 1;
fi
+ JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
Review Comment:
unused
##########
scripts/tools/tsfile/validate-tsfile.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.validate.TsFileValidationTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
$JVM-OPTS should follow closely behind "$JAVA"
##########
scripts/conf/confignode-env.sh:
##########
@@ -197,6 +197,7 @@ if [ -z $JAVA ] ; then
exit 1;
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
Review Comment:
remove this, append to CONFIGNODE_JVM_OPTS
##########
scripts/tools/schema/print-pb-tree-file.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.schema.PBTreeFileSketchTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
```
"$JAVA" "$JVM_OPTS" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
```
##########
scripts/tools/ops/health_check.sh:
##########
@@ -372,6 +372,8 @@ system_settings_check() {
fi
}
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
Review Comment:
unused
##########
scripts/tools/tsfile/split-tsfile-tool.sh:
##########
@@ -40,12 +40,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.TsFileSplitTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
$JVM-OPTS should follow closely behind "$JAVA"
##########
scripts/tools/tsfile/print-tsfile.sh:
##########
@@ -41,12 +41,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.TsFileSketchTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
$JVM-OPTS should follow closely behind "$JAVA"
##########
scripts/tools/tsfile/settle-tsfile.sh:
##########
@@ -37,12 +37,14 @@ else
JAVA=java
fi
+JVM_OPTS="-Dsun.jnu.encoding=UTF-8 -Dfile.encoding=UTF-8"
+
CLASSPATH=""
for f in ${IOTDB_HOME}/lib/*.jar; do
CLASSPATH=${CLASSPATH}":"$f
done
MAIN_CLASS=org.apache.iotdb.db.tools.settle.TsFileSettleByCompactionTool
-"$JAVA" -cp "$CLASSPATH" "$MAIN_CLASS" "$@"
+"$JAVA" -cp "$CLASSPATH" "$JVM_OPTS" "$MAIN_CLASS" "$@"
Review Comment:
$JVM-OPTS should follow closely behind "$JAVA"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
