jt2594838 commented on code in PR #15984:
URL: https://github.com/apache/iotdb/pull/15984#discussion_r2218831383
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/tsfile/PipeTsFileResourceManager.java:
##########
@@ -74,13 +79,17 @@ public class PipeTsFileResourceManager {
* @return the hardlink or copied file
* @throws IOException when create hardlink or copy file failed
*/
- public File increaseFileReference(
- final File file, final boolean isTsFile, final @Nullable String
pipeName) throws IOException {
+ private File increaseFileReference(
+ final File file,
+ final boolean isTsFile,
+ final @Nullable String pipeName,
+ final @Nullable File sourceFile)
Review Comment:
Add some Javadoc for the new parameter.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/resource/tsfile/PipeTsFileResourceManager.java:
##########
@@ -74,13 +79,17 @@ public class PipeTsFileResourceManager {
* @return the hardlink or copied file
* @throws IOException when create hardlink or copy file failed
*/
- public File increaseFileReference(
- final File file, final boolean isTsFile, final @Nullable String
pipeName) throws IOException {
+ private File increaseFileReference(
+ final File file,
+ final boolean isTsFile,
+ final @Nullable String pipeName,
+ final @Nullable File sourceFile)
Review Comment:
Where is a non-null `sourceFile` passed to the method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
