JackieTien97 opened a new pull request, #16000: URL: https://github.com/apache/iotdb/pull/16000
This pull request introduces changes to improve the configuration and handling of the sort buffer size in IoTDB. The updates include increasing the default buffer size, adding a mechanism to calculate a dynamic default value based on memory configuration, and enabling hot-reload functionality for the sort buffer size property. ### Configuration Enhancements: * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java`](diffhunk://#diff-30d3dc10c256a0068e3b87dd128011b653b4a8ecd0f0bf1149979022b5d92ea7L418-R418): Increased the default value of `sortBufferSize` from `1MB` to `32MB` to optimize sort operations. * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java`](diffhunk://#diff-69b0a48cf603a45ebb8ae61c5728cc43c2966e92cadcd01e34e673fcd730e6f3R1093-R1112): Added a new method `loadSortBuffer` to dynamically calculate and set the default `sortBufferSize` based on available memory and query thread count. The method ensures a minimum buffer size of `32MB` or a calculated value, whichever is smaller. ### Hot-Reload Functionality: * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java`](diffhunk://#diff-69b0a48cf603a45ebb8ae61c5728cc43c2966e92cadcd01e34e673fcd730e6f3R2084-R2086): Integrated the `loadSortBuffer` method into the `loadHotModifiedProps` function, enabling hot-reload support for the `sort_buffer_size_in_bytes` property. ### Configuration File Updates: * [`iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template`](diffhunk://#diff-2b2faccaba0ea63f97843c8f9abfbbcd43da4cf5ced1b4f22048aef7d5a62672L1073-R1077): Updated the `sort_buffer_size_in_bytes` property description to reflect the new dynamic default value calculation and hot-reload capability. Changed the default value to `0`, indicating that the dynamic calculation should be used unless overridden. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
