Caideyipi commented on code in PR #16425: URL: https://github.com/apache/iotdb/pull/16425#discussion_r2357620750
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/schema/DeviceNormalSchema.java: ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.plan.analyze.cache.schema; + +import org.apache.iotdb.db.queryengine.common.schematree.IMeasurementSchemaInfo; + +import org.apache.tsfile.utils.RamUsageEstimator; +import org.apache.tsfile.write.schema.IMeasurementSchema; + +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ConcurrentMap; + +public class DeviceNormalSchema implements IDeviceSchema { + + static final int INSTANCE_SIZE = + (int) RamUsageEstimator.shallowSizeOfInstance(DeviceNormalSchema.class) + + (int) RamUsageEstimator.shallowSizeOfInstance(ConcurrentHashMap.class); + private final String database; + private final boolean isAligned; + + private final ConcurrentMap<String, SchemaCacheEntry> measurementMap = new ConcurrentHashMap<>(); + + public DeviceNormalSchema(final String database, final boolean isAligned) { + this.database = database; + this.isAligned = isAligned; + } + + public String getDatabase() { + return database; + } + + public boolean isAligned() { + return isAligned; + } + + public SchemaCacheEntry getSchemaCacheEntry(final String measurement) { + return measurementMap.get(measurement); + } + + public int update(final String[] measurements, final IMeasurementSchema[] schemas) { + int diff = 0; + if (schemas == null) { + return diff; + } + + final int length = measurements.length; + + for (int i = 0; i < length; ++i) { + // Skip this to avoid instance creation/gc for writing performance + if (measurements[i] == null || measurementMap.containsKey(measurements[i])) { + continue; + } Review Comment: Because we assume that the measurement schema is immutable previously. If it is mutable now, this shall not be skipped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
