Caideyipi commented on code in PR #16540:
URL: https://github.com/apache/iotdb/pull/16540#discussion_r2435703201
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/parser/table/TsFileInsertionEventTableParserTabletIterator.java:
##########
@@ -386,24 +421,31 @@ private void initChunkReader(final
AbstractAlignedChunkMetadata alignedChunkMeta
}
this.chunkReader = new TableChunkReader(timeChunk, valueChunkList, null);
+ this.modsInfoList =
+ ModsOperationUtil.initializeMeasurementMods(deviceID, measurementList,
modifications);
}
- private void fillMeasurementValueColumns(
+ private boolean fillMeasurementValueColumns(
final BatchData data, final Tablet tablet, final int rowIndex) {
final TsPrimitiveType[] primitiveTypes = data.getVector();
+ boolean needFillTime = false;
for (int i = deviceIdSize, size = dataTypeList.size(); i < size; i++) {
final TsPrimitiveType primitiveType = primitiveTypes[i - deviceIdSize];
- if (primitiveType == null) {
+ boolean isDelete = false;
+ if (primitiveType == null
+ || (isDelete = ModsOperationUtil.isDelete(data.currentTime(),
modsInfoList.get(i)))) {
switch (dataTypeList.get(i)) {
case TEXT:
case BLOB:
case STRING:
tablet.addValue(rowIndex, i, Binary.EMPTY_VALUE.getValues());
}
tablet.getBitMaps()[i].mark(rowIndex);
+ needFillTime = needFillTime || !isDelete;
Review Comment:
Shall we fill the time if all the row points are either null or deleted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
