Caideyipi commented on code in PR #16632:
URL: https://github.com/apache/iotdb/pull/16632#discussion_r2493667414
##########
iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/sink/PipeStatementTreePatternParseVisitorTest.java:
##########
@@ -75,140 +93,234 @@ public void testCreateTimeSeries() throws
IllegalPathException {
createTimeSeriesStatementToFilter.setProps(Collections.emptyMap());
createTimeSeriesStatementToFilter.setTags(Collections.emptyMap());
createTimeSeriesStatementToFilter.setAttributes(Collections.emptyMap());
- createTimeSeriesStatementToFilter.setAlias("a2");
+ createTimeSeriesStatementToFilter.setAlias("a3");
Assert.assertEquals(
- createTimeSeriesStatement,
+ createTimeSeriesStatementS1,
new PipeStatementTreePatternParseVisitor()
- .visitCreateTimeseries(createTimeSeriesStatement,
prefixPathPattern)
+ .visitCreateTimeseries(createTimeSeriesStatementS1,
prefixPathPattern)
.orElseThrow(AssertionError::new));
Assert.assertFalse(
new PipeStatementTreePatternParseVisitor()
.visitCreateTimeseries(createTimeSeriesStatementToFilter,
prefixPathPattern)
.isPresent());
+
Assert.assertEquals(
- createTimeSeriesStatement,
+ createTimeSeriesStatementS1,
new PipeStatementTreePatternParseVisitor()
- .visitCreateTimeseries(createTimeSeriesStatement,
multiplePathPattern)
+ .visitCreateTimeseries(createTimeSeriesStatementS1,
multiplePathPattern)
.orElseThrow(AssertionError::new));
Assert.assertFalse(
new PipeStatementTreePatternParseVisitor()
.visitCreateTimeseries(createTimeSeriesStatementToFilter,
multiplePathPattern)
.isPresent());
+
+ Assert.assertEquals(
+ createTimeSeriesStatementS1,
+ new PipeStatementTreePatternParseVisitor()
+ .visitCreateTimeseries(createTimeSeriesStatementS1,
exclusionPattern)
+ .orElseThrow(AssertionError::new));
+ Assert.assertFalse(
+ new PipeStatementTreePatternParseVisitor()
+ .visitCreateTimeseries(createTimeSeriesStatementS2,
exclusionPattern)
+ .isPresent());
+ Assert.assertFalse(
+ new PipeStatementTreePatternParseVisitor()
+ .visitCreateTimeseries(createTimeSeriesStatementToFilter,
exclusionPattern)
+ .isPresent());
}
@Test
public void testCreateAlignedTimeSeries() throws IllegalPathException {
- final CreateAlignedTimeSeriesStatement
expectedCreateAlignedTimeSeriesStatement =
- new CreateAlignedTimeSeriesStatement();
- expectedCreateAlignedTimeSeriesStatement.setDevicePath(new
PartialPath("root.db.device"));
-
expectedCreateAlignedTimeSeriesStatement.setMeasurements(Collections.singletonList("s1"));
- expectedCreateAlignedTimeSeriesStatement.setDataTypes(
- Collections.singletonList(TSDataType.FLOAT));
- expectedCreateAlignedTimeSeriesStatement.setEncodings(
- Collections.singletonList(TSEncoding.RLE));
- expectedCreateAlignedTimeSeriesStatement.setCompressors(
- Collections.singletonList(CompressionType.SNAPPY));
- expectedCreateAlignedTimeSeriesStatement.setTagsList(
- Collections.singletonList(Collections.emptyMap()));
- expectedCreateAlignedTimeSeriesStatement.setAttributesList(
- Collections.singletonList(Collections.emptyMap()));
-
expectedCreateAlignedTimeSeriesStatement.setAliasList(Collections.singletonList("a1"));
-
- final CreateAlignedTimeSeriesStatement
originalCreateAlignedTimeSeriesStatement =
- new CreateAlignedTimeSeriesStatement();
- originalCreateAlignedTimeSeriesStatement.setDevicePath(new
PartialPath("root.db.device"));
-
originalCreateAlignedTimeSeriesStatement.setMeasurements(Arrays.asList("s1",
"s2"));
- originalCreateAlignedTimeSeriesStatement.setDataTypes(
- Arrays.asList(TSDataType.FLOAT, TSDataType.BOOLEAN));
- originalCreateAlignedTimeSeriesStatement.setEncodings(
- Arrays.asList(TSEncoding.RLE, TSEncoding.PLAIN));
- originalCreateAlignedTimeSeriesStatement.setCompressors(
- Arrays.asList(CompressionType.SNAPPY, CompressionType.SNAPPY));
- originalCreateAlignedTimeSeriesStatement.setTagsList(
- Arrays.asList(Collections.emptyMap(), Collections.emptyMap()));
- originalCreateAlignedTimeSeriesStatement.setAttributesList(
- Arrays.asList(Collections.emptyMap(), Collections.emptyMap()));
- originalCreateAlignedTimeSeriesStatement.setAliasList(Arrays.asList("a1",
"a2"));
+ final CreateTimeSeriesStatement createTimeSeriesStatementS1 = new
CreateTimeSeriesStatement();
+ createTimeSeriesStatementS1.setPath(new
MeasurementPath("root.db.device.s1"));
+ createTimeSeriesStatementS1.setDataType(TSDataType.FLOAT);
+ createTimeSeriesStatementS1.setEncoding(TSEncoding.RLE);
+ createTimeSeriesStatementS1.setCompressor(CompressionType.SNAPPY);
+ createTimeSeriesStatementS1.setProps(Collections.emptyMap());
+ createTimeSeriesStatementS1.setTags(Collections.emptyMap());
+ createTimeSeriesStatementS1.setAttributes(Collections.emptyMap());
+ createTimeSeriesStatementS1.setAlias("a1");
+
+ final CreateTimeSeriesStatement createTimeSeriesStatementS2 = new
CreateTimeSeriesStatement();
+ createTimeSeriesStatementS2.setPath(new
MeasurementPath("root.db.device.s2")); // Different path
+ createTimeSeriesStatementS2.setDataType(TSDataType.INT32);
+ createTimeSeriesStatementS2.setEncoding(TSEncoding.PLAIN);
+ createTimeSeriesStatementS2.setCompressor(CompressionType.SNAPPY);
+ createTimeSeriesStatementS2.setProps(Collections.emptyMap());
+ createTimeSeriesStatementS2.setTags(Collections.emptyMap());
+ createTimeSeriesStatementS2.setAttributes(Collections.emptyMap());
+ createTimeSeriesStatementS2.setAlias("a2");
+
+ final CreateTimeSeriesStatement createTimeSeriesStatementToFilter =
+ new CreateTimeSeriesStatement();
+ createTimeSeriesStatementToFilter.setPath(new
MeasurementPath("root.db1.device.s1"));
+ createTimeSeriesStatementToFilter.setDataType(TSDataType.FLOAT);
+ createTimeSeriesStatementToFilter.setEncoding(TSEncoding.RLE);
+ createTimeSeriesStatementToFilter.setCompressor(CompressionType.SNAPPY);
+ createTimeSeriesStatementToFilter.setProps(Collections.emptyMap());
+ createTimeSeriesStatementToFilter.setTags(Collections.emptyMap());
+ createTimeSeriesStatementToFilter.setAttributes(Collections.emptyMap());
+ createTimeSeriesStatementToFilter.setAlias("a3");
Assert.assertEquals(
- expectedCreateAlignedTimeSeriesStatement,
+ createTimeSeriesStatementS1,
new PipeStatementTreePatternParseVisitor()
-
.visitCreateAlignedTimeseries(originalCreateAlignedTimeSeriesStatement,
fullPathPattern)
+ .visitCreateTimeseries(createTimeSeriesStatementS1,
prefixPathPattern)
.orElseThrow(AssertionError::new));
+ Assert.assertFalse(
+ new PipeStatementTreePatternParseVisitor()
+ .visitCreateTimeseries(createTimeSeriesStatementToFilter,
prefixPathPattern)
+ .isPresent());
+
+ Assert.assertEquals(
+ createTimeSeriesStatementS1,
+ new PipeStatementTreePatternParseVisitor()
+ .visitCreateTimeseries(createTimeSeriesStatementS1,
multiplePathPattern)
+ .orElseThrow(AssertionError::new));
+ Assert.assertFalse(
+ new PipeStatementTreePatternParseVisitor()
+ .visitCreateTimeseries(createTimeSeriesStatementToFilter,
multiplePathPattern)
+ .isPresent());
Assert.assertEquals(
- originalCreateAlignedTimeSeriesStatement,
+ createTimeSeriesStatementS1,
new PipeStatementTreePatternParseVisitor()
- .visitCreateAlignedTimeseries(
- originalCreateAlignedTimeSeriesStatement, multiplePathPattern)
+ .visitCreateTimeseries(createTimeSeriesStatementS1,
exclusionPattern)
.orElseThrow(AssertionError::new));
+ Assert.assertFalse(
+ new PipeStatementTreePatternParseVisitor()
+ .visitCreateTimeseries(createTimeSeriesStatementS2,
exclusionPattern)
+ .isPresent());
+ Assert.assertFalse(
+ new PipeStatementTreePatternParseVisitor()
+ .visitCreateTimeseries(createTimeSeriesStatementToFilter,
exclusionPattern)
+ .isPresent());
}
@Test
public void testAlterTimeSeries() throws IllegalPathException {
- final AlterTimeSeriesStatement alterTimeSeriesStatement = new
AlterTimeSeriesStatement(true);
+ final CreateAlignedTimeSeriesStatement expectedS1Only = new
CreateAlignedTimeSeriesStatement();
Review Comment:
May check the mismatch of content and title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
