HTHou commented on code in PR #16683:
URL: https://github.com/apache/iotdb/pull/16683#discussion_r2496726858


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/util/AstUtil.java:
##########
@@ -113,6 +118,23 @@ public static Object expressionToTsValue(Expression 
expression) {
       throw new SemanticException(
           String.format("Cannot insert identifier %s, please use string 
literal", expression));
     }
+    if (expression instanceof FunctionCall
+        && "to_object".equals(((FunctionCall) 
expression).getName().toString())) {
+      boolean isEOF =
+          (boolean)
+              ((BooleanLiteral) ((FunctionCall) 
expression).getArguments().get(0)).getTsValue();

Review Comment:
   Fixed



##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/util/AstUtil.java:
##########
@@ -113,6 +118,23 @@ public static Object expressionToTsValue(Expression 
expression) {
       throw new SemanticException(
           String.format("Cannot insert identifier %s, please use string 
literal", expression));
     }
+    if (expression instanceof FunctionCall
+        && "to_object".equals(((FunctionCall) 
expression).getName().toString())) {
+      boolean isEOF =
+          (boolean)
+              ((BooleanLiteral) ((FunctionCall) 
expression).getArguments().get(0)).getTsValue();
+      long offset =
+          (long) ((LongLiteral) ((FunctionCall) 
expression).getArguments().get(1)).getTsValue();

Review Comment:
   fixed



##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/util/AstUtil.java:
##########
@@ -113,6 +118,23 @@ public static Object expressionToTsValue(Expression 
expression) {
       throw new SemanticException(
           String.format("Cannot insert identifier %s, please use string 
literal", expression));
     }
+    if (expression instanceof FunctionCall
+        && "to_object".equals(((FunctionCall) 
expression).getName().toString())) {
+      boolean isEOF =
+          (boolean)
+              ((BooleanLiteral) ((FunctionCall) 
expression).getArguments().get(0)).getTsValue();
+      long offset =
+          (long) ((LongLiteral) ((FunctionCall) 
expression).getArguments().get(1)).getTsValue();
+      byte[] content =
+          ((Binary)

Review Comment:
   Fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to