Copilot commented on code in PR #16717:
URL: https://github.com/apache/iotdb/pull/16717#discussion_r2502702190
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/ExternalRPCService.java:
##########
@@ -71,7 +71,7 @@ public void initThriftServiceThread() throws
IllegalAccessException {
processor,
getID().getName(),
ThreadName.CLIENT_RPC_PROCESSOR.getName(),
- getBindIP(),
+ null,
Review Comment:
The change from `getBindIP()` to `null` represents a significant behavioral
modification. Consider adding a comment explaining that passing `null` causes
the service to bind to all available network interfaces (0.0.0.0 behavior),
rather than a specific address. This would help future maintainers understand
the intentional nature of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
