Copilot commented on code in PR #16707:
URL: https://github.com/apache/iotdb/pull/16707#discussion_r2507804498
##########
iotdb-core/ainode/iotdb/ainode/core/inference/pool_controller.py:
##########
@@ -277,7 +278,7 @@ def _expand_pool_on_device(*_):
)
pool.start()
self._register_pool(model_id, device_id, pool_id, pool,
result_queue)
- if not pool.ready_event.wait(timeout=30):
+ if not pool.ready_event.wait(timeout=300):
logger.error(
f"[Inference][Device-{device_id}][Pool-{pool_id}] Pool
failed to be ready in time"
Review Comment:
Timeout increased from 30 to 300 seconds (10x increase). This significantly
increases the potential wait time for pool initialization. Consider if this
extended timeout is necessary or if it masks an underlying performance issue
that should be addressed.
```suggestion
if not pool.ready_event.wait(timeout=30):
logger.error(
f"[Inference][Device-{device_id}][Pool-{pool_id}] Pool
failed to be ready in 30 seconds"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
