shizy818 commented on code in PR #16353: URL: https://github.com/apache/iotdb/pull/16353#discussion_r2646395850
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/cte/CteDataReader.java: ########## @@ -0,0 +1,58 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information + * * regarding copyright ownership. The ASF licenses this file + * * to you under the Apache License, Version 2.0 (the + * * "License"); you may not use this file except in compliance + * * with the License. You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, + * * software distributed under the License is distributed on an + * * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * * KIND, either express or implied. See the License for the + * * specific language governing permissions and limitations + * * under the License. + * + */ + +package org.apache.iotdb.db.utils.cte; + +import org.apache.iotdb.commons.exception.IoTDBException; + +import org.apache.tsfile.read.common.block.TsBlock; + +public interface CteDataReader { + /** + * Check if there is more data in CteDataReader. DiskSpillerReader may run out of current TsBlocks + * , then it needs to read from file and cache more data. This method should be called before + * next() to ensure that there is data to read. + * + * @throws IoTDBException the error occurs when reading data from fileChannel + */ + boolean hasNext() throws IoTDBException; + + /** + * output the cached data in CteDataReader, it needs to be called after hasNext() returns true. + * + * @return next TsBlock + */ + TsBlock next() throws IoTDBException; + + /** + * Close the CteDataReader and release resources. + * + * @throws IoTDBException the error occurs when closing fileChannel + */ + void close() throws IoTDBException; + + /** + * Get the bytes used by this CteDataReader. + * + * @return the bytes used by this CteDataReader + */ + long bytesUsed(); Review Comment: done ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/cte/CteDataReader.java: ########## @@ -0,0 +1,58 @@ +/* + * + * * Licensed to the Apache Software Foundation (ASF) under one + * * or more contributor license agreements. See the NOTICE file + * * distributed with this work for additional information + * * regarding copyright ownership. The ASF licenses this file + * * to you under the Apache License, Version 2.0 (the + * * "License"); you may not use this file except in compliance + * * with the License. You may obtain a copy of the License at + * * + * * http://www.apache.org/licenses/LICENSE-2.0 + * * + * * Unless required by applicable law or agreed to in writing, + * * software distributed under the License is distributed on an + * * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * * KIND, either express or implied. See the License for the + * * specific language governing permissions and limitations + * * under the License. + * + */ + +package org.apache.iotdb.db.utils.cte; + +import org.apache.iotdb.commons.exception.IoTDBException; + +import org.apache.tsfile.read.common.block.TsBlock; + +public interface CteDataReader { Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
