jt2594838 commented on code in PR #16936:
URL: https://github.com/apache/iotdb/pull/16936#discussion_r2644567647
##########
integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBDeletionIT.java:
##########
@@ -488,6 +488,58 @@ public void testDeleteByRangeComparison() throws
SQLException {
}
}
+ @Test
+ public void testDropAndAlter() throws SQLException {
Review Comment:
Remove the test because it does not make sense.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/DataRegion.java:
##########
@@ -3126,7 +3136,9 @@ private void
deleteDataInSealedFiles(Collection<TsFileResource> sealedTsFiles, M
} // else do nothing
}
- if (!deletedByFiles.isEmpty()) {
+ if (!deletedByFiles.isEmpty()
+ && !isDropMeasurementExist
+ && idPredicateType.equals(IDPredicate.IDPredicateType.NOP)) {
Review Comment:
<img width="1403" height="743" alt="image"
src="https://github.com/user-attachments/assets/025a2157-0c31-4a4f-9a0f-ce00a7157ef3";
/>
The judgement should be put here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
