CRZbulabula commented on code in PR #16957:
URL: https://github.com/apache/iotdb/pull/16957#discussion_r2649461645
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/audit/AbstractAuditLogger.java:
##########
@@ -47,4 +48,16 @@ public abstract class AbstractAuditLogger {
public boolean noNeedInsertAuditLog(IAuditEntity auditLogFields) {
return true;
}
+
+ public void recordAuditLog(final IAuditEntity auditEntity, final
Supplier<String> auditObject) {
Review Comment:
I don't think it is a good idea that roughly moving the `recordAuditLog`
function from AuthCheckImpl to AbstractAuditLogger, because the current
implementation is only for `OBJECT_AUTHENTICATION` audit. If u indeed require
this refactor, I know current change is for pipe audit, at least rename this
interface to `recordObjectAuthenticationAuditLog`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
